hairpins_overlap_fix #23948
Merged
hairpins_overlap_fix #23948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be related or completely seperate, please let me know if I should open a new issue for this (Issue is in all versions of 4 as well as this PR): video1844995041.mp4 |
mathesoncalum
approved these changes
Aug 8, 2024
RomanPudashkin
added a commit
to RomanPudashkin/MuseScore
that referenced
this pull request
Aug 9, 2024
|
@zacjansheski fixed. The stuttering happened because we parsed the same hairpin twice (main staff + tab). Thus, their events overlapped with each other. Now we will only parse hairpins on the main staff |
When a hairpin ends at the same tick at which the next RepeatSegment starts. See PR musescore#20374
RomanPudashkin
force-pushed
the
hairpins_overlap_fix
branch
from
335da2b
to
e65f2fc
Compare
|
Tested on MacOS 14, Windows 11, Ubuntu 22.04.3. Approved |
RomanPudashkin
added a commit
to RomanPudashkin/MuseScore
that referenced
this pull request
Aug 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23940
Also see: #20374 -- it fixed the same problem, but in that case, the hairpin started right after the repeat (that is, at the same tick where the repeat ends)